Board logo

標題: 點解Singleton在multi-threaded environment 唔好 [打印本頁]
作者: luckiejacky    時間: 2015-1-11 11:18     標題: 點解Singleton在multi-threaded environment 唔好

本帖最後由 luckiejacky 於 2015-1-11 11:23 編輯

http://lostechies.com/scottdensmore/2009/08/14/singletons-are-evil-part-2/


C++
我寫左個Singleton class在multi-threaded 環境下有Memory Leak
我在main logic (Application class 內的Destructor destroy 個Singleton
內的Heap objects) 都系有Leak，有什麼方法可以今個program robust D?

  1. class NavmeshSingleton
  2. {
  3. public:
  4.         virtual ~NavmeshSingleton()                               
  5.         {                 
  6.                 delete m_pObj;       
  7.                 delete m_NavMesher;
  8.         }


  11.         // use this object to get obj
  12.         static NavmeshSingleton* GetObj()       
  13.         {  
  14.                 if (!m_pObj) {
  15.                         m_pObj = new NavmeshSingleton();
  16.                        
  17.                 }
  18.                 return m_pObj;
  19.         }
  20.         static void SetObj(NavmeshSingleton* pObj)
  21.         {  
  22.                 m_pObj = pObj;
  23.         }

  25. private:
  26.         static NavmeshSingleton* m_pObj;
  27.         static NavMesher *m_NavMesher;                 

  29. private:
  30.         NavmeshSingleton()               
  31.         {       
  32.                 m_NavMesher = new NavMesher();                                         
  33.                 m_NavMesher->buildNavMesh(((CWarehouse*)g_Objs["Warehouse"])->m_Mesh->GetMesh());          
  34.         }

  36. public:
  37.         void findPath(const D3DXVECTOR3& from, const D3DXVECTOR3& to, std::vector<D3DXVECTOR3>& path) {                          
  38.                 m_NavMesher->findPath(from, to, path);                                  
  39.         }
  40. };
複製代碼


THX
作者: luckiejacky    時間: 2015-1-11 12:12

Okay, I explicitly delete the m_NavMesher and m_pObj;
in the main logic class.
And seems not leaking any more
作者: goldbug23    時間: 2015-1-12 10:58

回覆 2# luckiejacky

可以用std::unique_ptr.

還有要用atomic或mutex去access.




歡迎光臨 電腦領域 HKEPC Hardware (https://h0.hkepc.com/forum/) Powered by Discuz! 7.2